rdblue commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r725674654
##########
File path:
core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
##########
@@ -184,14 +184,18 @@ protected void refreshFromMetadataLocation(String
newLocation, Predicate<Excepti
"Table UUID does not match: current=%s != refreshed=%s",
currentMetadata.uuid(), newUUID);
}
- this.currentMetadata = newMetadata.get();
+ this.currentMetadata = validateRefreshedMetadata(newMetadata.get());
this.currentMetadataLocation = newLocation;
this.version = parseVersion(newLocation);
}
this.shouldRefresh = false;
}
- private String metadataFileLocation(TableMetadata metadata, String filename)
{
+ protected TableMetadata validateRefreshedMetadata(TableMetadata metadata) {
+ return metadata;
+ }
+
+ protected String metadataFileLocation(TableMetadata metadata, String
filename) {
Review comment:
Why did you make this `protected` instead of `private`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
