ajantha-bhat commented on a change in pull request #3257:
URL: https://github.com/apache/iceberg/pull/3257#discussion_r735286727
##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java
##########
@@ -214,22 +224,21 @@ public void renameTable(TableIdentifier from,
TableIdentifier toOriginal) {
throw new AlreadyExistsException("table %s already exists", to.name());
}
- Operations contents = ImmutableOperations.builder()
- .addOperations(
-
ImmutablePut.builder().key(NessieUtil.toKey(to)).contents(existingFromTable).build(),
- ImmutableDelete.builder().key(NessieUtil.toKey(from)).build())
+ CommitMultipleOperationsBuilder op = api.commitMultipleOperations()
.commitMeta(NessieUtil.buildCommitMetadata("iceberg rename table",
catalogOptions))
Review comment:
As in this PR we have improved commit message, Can we improve this
commit message by adding `from` and `to` table identifier in the commit message
as well?
##########
File path: versions.props
##########
@@ -23,7 +23,7 @@ javax.activation:activation = 1.1.1
org.glassfish.jaxb:jaxb-runtime = 2.3.3
software.amazon.awssdk:* = 2.15.7
org.scala-lang:scala-library = 2.12.10
-org.projectnessie:* = 0.9.2
+org.projectnessie:* = 0.11.0
Review comment:
Please also update the version in `mkdocs.yml` L: 35
##########
File path:
nessie/src/main/java/org/apache/iceberg/nessie/NessieTableOperations.java
##########
@@ -72,21 +79,37 @@ protected String tableName() {
return key.toString();
}
+ @Override
+ protected TableMetadata validateRefreshedMetadata(TableMetadata metadata) {
+ // Update the TableMetadata to use the last-column-id across all Nessie
references.
Review comment:
```suggestion
// Update the TableMetadata to use the latest global IDs across all
Nessie references.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
