pvary commented on a change in pull request #3252:
URL: https://github.com/apache/iceberg/pull/3252#discussion_r726034453
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -118,6 +120,36 @@ public void testCreateTableWithCaching() throws Exception {
}
}
+ @Test
+ public void testInitialize() {
+ Assertions.assertDoesNotThrow(() -> {
+ Map<String, String> properties = new HashMap<>();
Review comment:
nit: Maybe put this inside the call as the value is not used.
Also we usually suggest to use `Maps.newHashMap()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
