nastra commented on a change in pull request #3353:
URL: https://github.com/apache/iceberg/pull/3353#discussion_r734685955
##########
File path: build.gradle
##########
@@ -577,19 +577,32 @@ String getVersionFromFile() {
}
String getProjectVersion() {
- if (isVersionFileExists()) {
- return getVersionFromFile()
+ String version = ""
Review comment:
it does, but doing concat with an empty string makes things slightly
easier in case there's no `version`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
