nastra commented on a change in pull request #3353:
URL: https://github.com/apache/iceberg/pull/3353#discussion_r735303416
##########
File path: dev/source-release.sh
##########
@@ -85,7 +85,7 @@ echo "Preparing source for $tagrc"
echo "Adding version.txt and tagging release..."
echo $version > $projectdir/version.txt
git add $projectdir/version.txt
-git commit -m "Add version.txt for release $version" $projectdir/version.txt
+git commit -m "Update version.txt for release $version" $projectdir/version.txt
Review comment:
I didn't run that script before but it would be just overwriting
whatever is in `version.txt`. I'll try your PR as it's definitely helpful to do
a dry-run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
