kbendick commented on a change in pull request #3353:
URL: https://github.com/apache/iceberg/pull/3353#discussion_r734747667
##########
File path: dev/source-release.sh
##########
@@ -85,7 +85,7 @@ echo "Preparing source for $tagrc"
echo "Adding version.txt and tagging release..."
echo $version > $projectdir/version.txt
git add $projectdir/version.txt
-git commit -m "Add version.txt for release $version" $projectdir/version.txt
+git commit -m "Update version.txt for release $version" $projectdir/version.txt
Review comment:
Just to verify: did you try running this script? It previously assumed
we didn't have the version file and only checked it in during the release phase
(the `git add` above).
I would have thought it would fail at the `git add` above. I guess since
it's being overwritten by line 86 above that it can successfully pass `git add`
every time?
I have a [WIP on a version with a test
flag](https://github.com/apache/iceberg/pull/3322), but if you just exit before
entering your keychain password that works just fine as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
