kbendick commented on a change in pull request #3323:
URL: https://github.com/apache/iceberg/pull/3323#discussion_r735258419



##########
File path: 
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java
##########
@@ -115,10 +129,12 @@ public void setupTable() throws IOException {
 
   @Test
   public void testCommitTxnWithoutDataFiles() throws Exception {
+    Assume.assumeTrue("Only support unpartitioned table.", !partitioned);

Review comment:
       Nit: can you further clarify what is not supported in the assumption 
statements? Like the thing causing the assumption to be violated is that the 
table is partitioned, but can you add what is being violated? It seems as 
though presently the whole process doesn't support partitioned tables, is that 
correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to