Reo-LEI commented on a change in pull request #3323:
URL: https://github.com/apache/iceberg/pull/3323#discussion_r735371033
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java
##########
@@ -616,14 +651,15 @@ public void testFlinkManifests() throws Exception {
@Test
public void testDeleteFiles() throws Exception {
Assume.assumeFalse("Only support equality-delete in format v2.",
formatVersion < 2);
+ Assume.assumeTrue("Only support unpartitioned table.", !partitioned);
Review comment:
I think `assumeTrue` will make it easier to understand. If you want to
change to `assumeFalse`, I think that is ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
