Reo-LEI commented on a change in pull request #3323:
URL: https://github.com/apache/iceberg/pull/3323#discussion_r735368383
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergFilesCommitter.java
##########
@@ -115,10 +129,12 @@ public void setupTable() throws IOException {
@Test
public void testCommitTxnWithoutDataFiles() throws Exception {
+ Assume.assumeTrue("Only support unpartitioned table.", !partitioned);
Review comment:
Actually, the `IcebergFilesCommitter` will do the same work for
partition and unpartition table before emit `CommitResult`. So we only need to
test `IcebergFilesCommitter` by partition or unpartition table. And the whole
test are bese on unpartition table before. But this PR need to emit the
`CommitResult` which is group by partition, So I add the `partitioned` param
and add this assume to keep the original test.
Maybe we could change to `Only test for unpartitioned table.`? What do you
think?
But the `partitioned` param doesn't seem necessary now, I will remove the
partitioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
