aokolnychyi commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r736822802
##########
File path:
spark/v3.0/spark3/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -51,9 +63,11 @@
@BenchmarkMode(Mode.SingleShotTime)
public abstract class IcebergSourceBenchmark {
+ private static final Logger LOG =
LoggerFactory.getLogger(IcebergSourceBenchmark.class);
private final Configuration hadoopConf = initHadoopConf();
private final Table table = initTable();
private SparkSession spark;
+ private static final long TARGET_FILE_SIZE_IN_BYTES = 50L * 1024 * 1024;
Review comment:
nit: static vars should be grouped together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
