RussellSpitzer commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r737652841
##########
File path:
spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -51,6 +63,9 @@
@BenchmarkMode(Mode.SingleShotTime)
public abstract class IcebergSourceBenchmark {
+ private static final Logger LOG =
LoggerFactory.getLogger(IcebergSourceBenchmark.class);
+ private static final long TARGET_FILE_SIZE_IN_BYTES = 50L * 1024 * 1024;
Review comment:
we should probably be testing files which are closer to what we actually
expect, (512 mb I believe is still our default?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
