RussellSpitzer commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r737623252
##########
File path: core/src/main/java/org/apache/iceberg/deletes/Deletes.java
##########
@@ -107,6 +108,29 @@ public static StructLikeSet
toEqualitySet(CloseableIterable<StructLike> eqDelete
}
}
+ public static Roaring64Bitmap toPositionBitMap(CharSequence dataLocation,
+ CloseableIterable<? extends StructLike> deleteFile) {
+ return toPositionBitMap(dataLocation, ImmutableList.of(deleteFile));
+ }
+
+ public static <T extends StructLike> Roaring64Bitmap
toPositionBitMap(CharSequence dataLocation,
+ List<CloseableIterable<T>> deleteFiles) {
+ DataFileFilter<T> locationFilter = new DataFileFilter<>(dataLocation);
+ List<CloseableIterable<Long>> positions = Lists.transform(deleteFiles,
deletes ->
+ CloseableIterable.transform(locationFilter.filter(deletes), row ->
(Long) POSITION_ACCESSOR.get(row)));
+ return toPositionBitMap(CloseableIterable.concat(positions));
+ }
+
+ public static Roaring64Bitmap toPositionBitMap(CloseableIterable<Long>
posDeletes) {
+ try (CloseableIterable<Long> deletes = posDeletes) {
+ Roaring64Bitmap bitmap = new Roaring64Bitmap();
Review comment:
How is the memory usage with an uncompressed bitmap? My thought here
would be that the actual number of rows in a file is probably never actually
that huge relatively, not a big deal though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
