kbendick edited a comment on pull request #3463: URL: https://github.com/apache/iceberg/pull/3463#issuecomment-960243221
> A few updates needed in the checkstyle descriptions and comments, but this is a good catch. > > Is there anything in `org.apache.arrow.util` we might ever need? > > I think it's safe to add this and then it can be reconsidered or made more explicit to the Preconditions check otherwise. > > I know that my Intellij autoimports `Preconditions` from all sorts of places and it's easy to miss. I went and checked the arrow library, and the only things I found in `org.apache.arrow.util` were `Preconditions` and something called `AutoCloseables` and something called `Collections2` (a test class). Doubt we'll need those and we can update this if we do. EDIT: I also went looking at `org.assertj.core.util`, and everything was copied from Guava or elsewhere. I think this is safe to do as well and we can also update it need be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
