kbendick commented on a change in pull request #3463:
URL: https://github.com/apache/iceberg/pull/3463#discussion_r742385547
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like it should maybe be
`BanUnrelocatedAssertjUtilClasses`?
If we're looking to only ban the guava ones, maybe `illegalClasses` needs to
be more specifc to `org.apache.arrow.util.Preconditions`?
EDIT: I checked and there's pretty much only `Preconditions` and other
things available in our bundled-guava. Might need a unique id but otherwise
this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
