jackye1995 commented on a change in pull request #3463:
URL: https://github.com/apache/iceberg/pull/3463#discussion_r742411839
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I was mostly following this:
```
<module name="IllegalImport">
<property name="id" value="BanUnrelocatedGuavaClasses"/>
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
```
I am actually not sure if the ID has to be unique, let me check
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Ah I see, so that's a user-defined name, then let me update it
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I was mostly following this:
```
<module name="IllegalImport">
<property name="id" value="BanUnrelocatedGuavaClasses"/>
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
```
I am actually not sure if the ID has to be unique, let me check
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Ah I see, so that's a user-defined name, then let me update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
