kbendick commented on a change in pull request #3463:
URL: https://github.com/apache/iceberg/pull/3463#discussion_r742385843
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Same here, but `BanUnrelocatedArrowUtilClasses`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Same note on comment.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava, but this looks like it bans all of
org.assertj.core.util.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`?
If we're looking to only ban the guava ones, maybe `illegalClasses` needs to
be more specifc to `org.apache.arrow.util.Preconditions`?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
Review comment:
Should this be `illegalPkgs` like on line 189?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava, but this looks like it bans all of
org.assertj.core.util.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Same note on comment.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Same here, but `BanUnrelocatedArrowUtilClasses`.
EDIT: I checked and they all appear to be Guava classes, so this is probably
fine. We might need a unique value though for `id`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like it should maybe be
`BanUnrelocatedAssertjUtilClasses`?
If we're looking to only ban the guava ones, maybe `illegalClasses` needs to
be more specifc to `org.apache.arrow.util.Preconditions`?
EDIT: I checked and there's pretty much only `Preconditions` and other
things available in our bundled-guava. Might need a unique id but otherwise
this is fine.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
Review comment:
This one should also probably be `illegalPkgs`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I checked myself when I was verifying this (not 100% used to updating
these files), and they do not have to be unique.
It's just used in the output it seems, like this example where I added an
import.
```
> Task :iceberg-arrow:checkstyleMain FAILED
[ant:checkstyle] [ERROR]
/Users/kylebendickson/repos/iceberg-kyle/arrow/src/main/java/org/apache/iceberg/arrow/ArrowAllocation.java:23:1:
Use org.apache.iceberg.relocated.* classes from bundled-guava module instead.
[BanUnrelocatedGuavaClasses]
```
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I checked myself when I was verifying this (not 100% used to updating
these files), and they do not have to be unique.
It's just used in the output it seems, like this example where I added an
import.
```
> Task :iceberg-arrow:checkstyleMain FAILED
[ant:checkstyle] [ERROR]
/iceberg/arrow/src/main/java/org/apache/iceberg/arrow/ArrowAllocation.java:23:1:
Use org.apache.iceberg.relocated.* classes from bundled-guava module instead.
[BanUnrelocatedGuavaClasses]
```
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Same here, but `BanUnrelocatedArrowUtilClasses`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Same note on comment.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava, but this looks like it bans all of
org.assertj.core.util.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like i was copy pasted. Should maybe be
`BanUnrelocatedAssertjUtilClasses`?
If we're looking to only ban the guava ones, maybe `illegalClasses` needs to
be more specifc to `org.apache.arrow.util.Preconditions`?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
Review comment:
Should this be `illegalPkgs` like on line 189?
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Comment still references guava, but this looks like it bans all of
org.assertj.core.util.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
Review comment:
Same note on comment.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Same here, but `BanUnrelocatedArrowUtilClasses`.
EDIT: I checked and they all appear to be Guava classes, so this is probably
fine. We might need a unique value though for `id`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
Nit: The value here looks like it should maybe be
`BanUnrelocatedAssertjUtilClasses`?
If we're looking to only ban the guava ones, maybe `illegalClasses` needs to
be more specifc to `org.apache.arrow.util.Preconditions`?
EDIT: I checked and there's pretty much only `Preconditions` and other
things available in our bundled-guava. Might need a unique id but otherwise
this is fine.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.assertj.core.util"/>
+ <message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
+ </module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
+ <property name="illegalClasses" value="org.apache.arrow.util"/>
Review comment:
This one should also probably be `illegalPkgs`.
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I checked myself when I was verifying this (not 100% used to updating
these files), and they do not have to be unique.
It's just used in the output it seems, like this example where I added an
import.
```
> Task :iceberg-arrow:checkstyleMain FAILED
[ant:checkstyle] [ERROR]
/Users/kylebendickson/repos/iceberg-kyle/arrow/src/main/java/org/apache/iceberg/arrow/ArrowAllocation.java:23:1:
Use org.apache.iceberg.relocated.* classes from bundled-guava module instead.
[BanUnrelocatedGuavaClasses]
```
##########
File path: .baseline/checkstyle/checkstyle.xml
##########
@@ -189,6 +189,16 @@
<property name="illegalPkgs" value="com.google.common"/>
<message key="import.illegal" value="Use
org.apache.iceberg.relocated.* classes from bundled-guava module instead."/>
</module>
+ <module name="IllegalImport">
+ <property name="id" value="BanUnrelocatedGuavaClasses"/>
Review comment:
I checked myself when I was verifying this (not 100% used to updating
these files), and they do not have to be unique.
It's just used in the output it seems, like this example where I added an
import.
```
> Task :iceberg-arrow:checkstyleMain FAILED
[ant:checkstyle] [ERROR]
/iceberg/arrow/src/main/java/org/apache/iceberg/arrow/ArrowAllocation.java:23:1:
Use org.apache.iceberg.relocated.* classes from bundled-guava module instead.
[BanUnrelocatedGuavaClasses]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
