aokolnychyi commented on a change in pull request #3461: URL: https://github.com/apache/iceberg/pull/3461#discussion_r745038795
########## File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.spark; + +import java.util.List; +import org.apache.iceberg.DistributionMode; +import org.apache.iceberg.Table; +import org.apache.iceberg.transforms.SortOrderVisitor; +import org.apache.iceberg.util.SortOrderUtil; +import org.apache.spark.sql.connector.distributions.Distribution; +import org.apache.spark.sql.connector.distributions.Distributions; +import org.apache.spark.sql.connector.distributions.OrderedDistribution; +import org.apache.spark.sql.connector.expressions.SortOrder; + +public class SparkDistributionAndOrderingUtil { + + private SparkDistributionAndOrderingUtil() { + } + + public static Distribution buildRequiredDistribution(Table table, DistributionMode distributionMode) { + switch (distributionMode) { + case NONE: + return Distributions.unspecified(); + + case HASH: + if (table.spec().isUnpartitioned()) { + return Distributions.unspecified(); + } else { + return Distributions.clustered(Spark3Util.toTransforms(table.spec())); + } + + case RANGE: + if (table.spec().isUnpartitioned() && table.sortOrder().isUnsorted()) { + return Distributions.unspecified(); + } else { + org.apache.iceberg.SortOrder requiredSortOrder = SortOrderUtil.buildSortOrder(table); + return Distributions.ordered(convert(requiredSortOrder)); + } + + default: + throw new IllegalArgumentException("Unsupported distribution mode: " + distributionMode); + } + } + + public static SortOrder[] buildRequiredOrdering(Table table, Distribution distribution) { Review comment: I did. In most places, we pass `SparkSession` and `Table` first so I matched it for consistency. What do you think? I kind of make sense to me to go from the most "generic" to the most "specific" param in method params. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
