aokolnychyi commented on a change in pull request #3461:
URL: https://github.com/apache/iceberg/pull/3461#discussion_r745042713



##########
File path: 
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java
##########
@@ -53,4 +53,11 @@ private SparkWriteOptions() {
 
   // Controls whether to allow writing timestamps without zone info
   public static final String HANDLE_TIMESTAMP_WITHOUT_TIMEZONE = 
"handle-timestamp-without-timezone";
+
+  // Overrides the default distribution mode for a write operation
+  public static final String DISTRIBUTION_MODE = "distribution-mode";
+
+  // Controls whether to ignore the table sort order during a write operation
+  public static final String IGNORE_SORT_ORDER = "ignore-sort-order";

Review comment:
       I went back and forth on this one and was not sure whether I am 
overthinking. I did not have a good name so kept it as is. Let me think more on 
this. I think I like having only one property to disable both. That's easier. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to