RussellSpitzer commented on a change in pull request #3461:
URL: https://github.com/apache/iceberg/pull/3461#discussion_r745057423
##########
File path: core/src/main/java/org/apache/iceberg/util/SortOrderUtil.java
##########
@@ -44,7 +44,11 @@ public static SortOrder buildSortOrder(Table table) {
return buildSortOrder(table.schema(), table.spec(), table.sortOrder());
}
- public static SortOrder buildSortOrder(Schema schema, PartitionSpec spec,
SortOrder sortOrder) {
+ public static SortOrder buildSortOrder(Table table, SortOrder sortOrder) {
Review comment:
Small nit here, but I would add just a note that this builds a sort
order using both the table partition spec and the user supplied sort order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
