aokolnychyi commented on a change in pull request #3529:
URL: https://github.com/apache/iceberg/pull/3529#discussion_r746876107
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java
##########
@@ -71,7 +72,8 @@ public static Distribution buildRequiredDistribution(Table
table, DistributionMo
}
public static SortOrder[] convert(org.apache.iceberg.SortOrder sortOrder) {
- List<OrderField> converted = SortOrderVisitor.visit(sortOrder, new
SortOrderToSpark());
+ Map<Integer, String> quotedNameById =
SparkSchemaUtil.indexQuotedNameById(sortOrder.schema());
Review comment:
I am a bit worried about the performance. We index all columns. We could
add some sort of a filter to the indexing logic to only pick particular field
IDs. It will be more involved so let me know what everybody thinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
