rdblue commented on a change in pull request #3529:
URL: https://github.com/apache/iceberg/pull/3529#discussion_r748894975
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SortOrderToSpark.java
##########
@@ -19,44 +19,56 @@
package org.apache.iceberg.spark;
+import java.util.Map;
import org.apache.iceberg.NullOrder;
import org.apache.iceberg.SortDirection;
import org.apache.iceberg.transforms.SortOrderVisitor;
class SortOrderToSpark implements SortOrderVisitor<OrderField> {
+
+ private final Map<Integer, String> quotedNameById;
+
+ SortOrderToSpark(Map<Integer, String> quotedNameById) {
+ this.quotedNameById = quotedNameById;
Review comment:
I would probably make this accept a `Schema` instead. I agree that it
would be easier to follow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
