rdblue commented on a change in pull request #3529:
URL: https://github.com/apache/iceberg/pull/3529#discussion_r748894894
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkDistributionAndOrderingUtil.java
##########
@@ -71,7 +72,8 @@ public static Distribution buildRequiredDistribution(Table
table, DistributionMo
}
public static SortOrder[] convert(org.apache.iceberg.SortOrder sortOrder) {
- List<OrderField> converted = SortOrderVisitor.visit(sortOrder, new
SortOrderToSpark());
+ Map<Integer, String> quotedNameById =
SparkSchemaUtil.indexQuotedNameById(sortOrder.schema());
Review comment:
I don't think this is going to matter much. Schema operations are done
in planning, not in a tight loop. And even with thousands of columns, this
shouldn't take that long. If it were done in a loop, I think we'd want to care.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
