aokolnychyi commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r748450646
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -407,35 +412,55 @@ public void setBatchSize(int batchSize) {
}
private static final class PositionVectorReader extends
VectorizedArrowReader {
+ private final Field arrowField =
ArrowSchemaUtil.convert(MetadataColumns.ROW_POSITION);
+ private final BufferAllocator bufferAllocator =
ArrowAllocation.rootAllocator();
+ private final boolean setArrowValidityVector;
private long rowStart;
+ private int batchSize;
+ private FieldVector vec;
private NullabilityHolder nulls;
+ PositionVectorReader(boolean setArrowValidityVector) {
+ this.setArrowValidityVector = setArrowValidityVector;
+ }
+
@Override
public VectorHolder read(VectorHolder reuse, int numValsToRead) {
- Field arrowField = ArrowSchemaUtil.convert(MetadataColumns.ROW_POSITION);
- FieldVector vec =
arrowField.createVector(ArrowAllocation.rootAllocator());
-
- if (reuse != null) {
- vec.setValueCount(0);
- nulls.reset();
+ if (reuse == null) {
+ this.vec = newVector();
+ this.nulls = newNullabilityHolder();
} else {
- ((BigIntVector) vec).allocateNew(numValsToRead);
- for (int i = 0; i < numValsToRead; i += 1) {
- vec.getDataBuffer().setLong(i * Long.BYTES, rowStart + i);
- }
- for (int i = 0; i < numValsToRead; i += 1) {
- BitVectorHelper.setBit(vec.getValidityBuffer(), i);
+ vec.setValueCount(0);
Review comment:
I had that initially but then we
[discussed](https://github.com/apache/iceberg/pull/3533#discussion_r747722269)
that the values are never null so calling `setNotNulls` for each batch seemed
redundant. That's why I moved that to the method that inits the nullability
holder and simply reuse the same nullability holder. What do you think, @nastra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
