rdblue commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r748885681
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -448,6 +473,14 @@ public String toString() {
@Override
public void setBatchSize(int batchSize) {
+ this.batchSize = (batchSize == 0) ? DEFAULT_BATCH_SIZE : batchSize;
Review comment:
I think this needs to reallocate the nullability holder if batch size
increased, or else a batch size change could cause it an underflow when
accessing nullability. Right now, it doesn't really matter because batch size
never changes (it's set during the vectorized parquet constructor) but this
should still implement the contract, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
