RussellSpitzer commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r750705810
##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -79,8 +79,11 @@ public static Snapshot oldestAncestorAfter(Table table, Long
timestampMillis) {
return null;
}
- while (current.parentId() != null &&
table.snapshot(current.parentId()).timestampMillis() >= timestamp) {
- current = table.snapshot(current.parentId());
+ for (Snapshot snapshot : table.snapshots()) {
Review comment:
I think you still need to do the "parent" look up here since I believe
this will pick up uncommitted and snapshots which have been rolled back. Ie
snapshots which exist but are not part of the current history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
