RussellSpitzer commented on a change in pull request #3039:
URL: https://github.com/apache/iceberg/pull/3039#discussion_r750707333
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
##########
@@ -247,6 +249,46 @@ public void
testReadingStreamFromTimestampStartWithExistingTimestamp() throws Ex
Assertions.assertThat(actual).containsExactlyInAnyOrderElementsOf(Iterables.concat(expected));
}
+ @SuppressWarnings("unchecked")
+ @Test
+ @Ignore("Existing logic doesn't work when the expired snapshot gets deleted")
Review comment:
Shouldn't we add a test for checking the new functionality? I would
rather we didn't just add in a test that we don't run.
As I mentioned above you may want to add in a test for reading a stream from
a timestamp after a rollback, so there exists old snapshots which are not live.
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
##########
@@ -247,6 +249,46 @@ public void
testReadingStreamFromTimestampStartWithExistingTimestamp() throws Ex
Assertions.assertThat(actual).containsExactlyInAnyOrderElementsOf(Iterables.concat(expected));
}
+ @SuppressWarnings("unchecked")
+ @Test
+ @Ignore("Existing logic doesn't work when the expired snapshot gets deleted")
Review comment:
Shouldn't we add a test for checking the new functionality? I would
rather we didn't just add in a test that we don't run.
As I mentioned above you may want to add in a test for reading a stream from
a timestamp after a rollback, so there exists old snapshots which are not live
and should be ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
