openinx commented on a change in pull request #3596:
URL: https://github.com/apache/iceberg/pull/3596#discussion_r754921787
##########
File path:
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunTestUtility.java
##########
@@ -25,17 +25,22 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class AliyunOSSTestUtility {
- private static final Logger LOG =
LoggerFactory.getLogger(AliyunOSSTestUtility.class);
- private static final String ALIYUN_TEST_OSS_TEST_RULE_CLASS =
"ALIYUN_TEST_OSS_TEST_RULE_CLASS";
+public class AliyunTestUtility {
Review comment:
If this utility is not only for aliyun OSS, then I think it's better to
move this class out of the oss package `org.apache.iceberg.aliyun.oss` ? maybe
`org.apache.iceberg.aliyun` is a better choice ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
