openinx commented on a change in pull request #3596:
URL: https://github.com/apache/iceberg/pull/3596#discussion_r754927863
##########
File path:
aliyun/src/test/java/org/apache/iceberg/aliyun/oss/AliyunTestUtility.java
##########
@@ -56,4 +61,28 @@ public static AliyunOSSTestRule initialize() {
return testRule;
}
+
+ public static String testOSSEndpoint() {
+ return systemEnv(ALIYUN_TEST_OSS_ENDPOINT);
+ }
+
+ public static String testAccessKeyId() {
+ return systemEnv(ALIYUN_TEST_ACCESS_KEY_ID);
+ }
+
+ public static String testAccessKeySecret() {
+ return systemEnv(ALIYUN_TEST_ACCESS_KEY_SECRET);
+ }
+
+ public static String testBucketName() {
+ return systemEnv(ALIYUN_TEST_BUCKET_NAME);
+ }
+
+ public static String testOssKeyPrefix() {
+ return systemEnv(ALIYUN_TEST_OSS_KEY_PREFIX);
+ }
+
+ private static String systemEnv(String name) {
Review comment:
+1 for @jackye1995 's comment .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
