openinx commented on a change in pull request #3596:
URL: https://github.com/apache/iceberg/pull/3596#discussion_r763597855
##########
File path: aliyun/src/test/java/org/apache/iceberg/aliyun/AliyunTestUtility.java
##########
@@ -56,4 +62,24 @@ public static AliyunOSSTestRule initialize() {
return testRule;
}
+
+ public static String ossEndpoint() {
+ return System.getenv(ALIYUN_TEST_OSS_ENDPOINT);
+ }
+
+ public static String accessKeyId() {
+ return System.getenv(ALIYUN_TEST_ACCESS_KEY_ID);
+ }
+
+ public static String accessKeySecret() {
+ return System.getenv(ALIYUN_TEST_ACCESS_KEY_SECRET);
+ }
+
+ public static String bucketName() {
Review comment:
Similar thing, pls add the prefix `oss`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
