rdblue commented on a change in pull request #3670:
URL: https://github.com/apache/iceberg/pull/3670#discussion_r763448386
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -647,6 +647,8 @@ public void testIcebergAndHmsTableProperties() throws
Exception {
Assert.assertEquals(HiveIcebergInputFormat.class.getName(),
hmsTable.getSd().getInputFormat());
Assert.assertEquals(HiveIcebergOutputFormat.class.getName(),
hmsTable.getSd().getOutputFormat());
Assert.assertEquals(HiveIcebergSerDe.class.getName(),
hmsTable.getSd().getSerdeInfo().getSerializationLib());
+ // Add 1 second delay to reflect DDL_TIME change in HMS
+ Thread.sleep(1000);
Review comment:
Sleeping for 1 second really adds up and makes tests slow. Instead, what
about always setting the property to the last snapshot timestamp? That way you
get more accurate information -- the timestamp of the last snapshot -- and you
have something that you can also validate in a test using `Assert.equals`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
