kevinjqliu commented on a change in pull request #3670:
URL: https://github.com/apache/iceberg/pull/3670#discussion_r763595653
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -647,6 +647,8 @@ public void testIcebergAndHmsTableProperties() throws
Exception {
Assert.assertEquals(HiveIcebergInputFormat.class.getName(),
hmsTable.getSd().getInputFormat());
Assert.assertEquals(HiveIcebergOutputFormat.class.getName(),
hmsTable.getSd().getOutputFormat());
Assert.assertEquals(HiveIcebergSerDe.class.getName(),
hmsTable.getSd().getSerdeInfo().getSerializationLib());
+ // Add 1 second delay to reflect DDL_TIME change in HMS
+ Thread.sleep(1000);
Review comment:
> Sleeping for 1 second really adds up and makes tests slow... what
about always setting the property to the last snapshot timestamp?
I agree sleeping for 1 second is not ideal. Wasn't sure about a good
alternative. Currently, the test runs fast enough that the table creation and
subsequent snapshot write all happen in the same unix timestamp. So I can't
write a test that shows the timestamp had changed, something like (table
creation timestamp < write timestamp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
