kbendick commented on a change in pull request #3670:
URL: https://github.com/apache/iceberg/pull/3670#discussion_r766248740



##########
File path: 
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -362,6 +362,9 @@ private void setHmsTableParameters(String 
newMetadataLocation, Table tbl, Map<St
     // remove any props from HMS that are no longer present in Iceberg table 
props
     obsoleteProps.forEach(parameters::remove);
 
+    // remove any props that are controlled by HMS so it can handle them
+    parameters.remove(hive_metastoreConstants.DDL_TIME);

Review comment:
       Does `INSERT` not affect the DDL_TIME? I'm not as familiar with it, but 
that's surprising to me based on how I hear people using it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to