nastra commented on a change in pull request #3697:
URL: https://github.com/apache/iceberg/pull/3697#discussion_r765762604
##########
File path: core/src/test/java/org/apache/iceberg/MockFileScanTask.java
##########
@@ -55,17 +66,35 @@ public static MockFileScanTask mockTaskWithDeletes(long
length, int nDeletes) {
DataFile mockFile = Mockito.mock(DataFile.class);
Mockito.when(mockFile.fileSizeInBytes()).thenReturn(length);
- return new MockFileScanTask(mockFile, mockDeletes);
+ return MockFileScanTask.of(mockFile, mockDeletes);
}
@Override
- public long length() {
- return length;
- }
+ @Nullable
Review comment:
we're overriding all of those only to mark them as `@Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
