nastra commented on a change in pull request #3697:
URL: https://github.com/apache/iceberg/pull/3697#discussion_r765765437
##########
File path: core/src/main/java/org/apache/iceberg/BaseFileScanTask.java
##########
@@ -20,71 +20,69 @@
package org.apache.iceberg;
import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;
+import javax.annotation.Nullable;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.ResidualEvaluator;
import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
-
-class BaseFileScanTask implements FileScanTask {
- private final DataFile file;
- private final DeleteFile[] deletes;
- private final String schemaString;
- private final String specString;
- private final ResidualEvaluator residuals;
-
- private transient PartitionSpec spec = null;
-
- BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString,
String specString,
- ResidualEvaluator residuals) {
- this.file = file;
- this.deletes = deletes != null ? deletes : new DeleteFile[0];
- this.schemaString = schemaString;
- this.specString = specString;
- this.residuals = residuals;
+import org.immutables.value.Value;
+
[email protected]
+abstract class BaseFileScanTask implements FileScanTask {
Review comment:
if we want to make this JSON serializable/deserialize, all we have to do
is
```
@JsonSerialize(as = ImmutableBaseFileScanTask.class)
@JsonDeserialize(as = ImmutableBaseFileScanTask.class)
```
I have omitted this for now until we really need it. The same applies for
all the other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
