nastra commented on a change in pull request #3697:
URL: https://github.com/apache/iceberg/pull/3697#discussion_r765767965
##########
File path: core/src/main/java/org/apache/iceberg/ManifestEntriesTable.java
##########
@@ -110,46 +111,56 @@ protected TableScan newRefinedScan(TableOperations ops,
Table table, Schema sche
ResidualEvaluator residuals = ResidualEvaluator.unpartitioned(filter);
return CloseableIterable.transform(manifests, manifest ->
- new ManifestReadTask(ops.io(), manifest, schema(), schemaString,
specString, residuals,
+ ManifestEntriesReadTask.of(ops.io(), manifest, schema(),
schemaString, specString, residuals,
ops.current().specsById()));
}
}
- static class ManifestReadTask extends BaseFileScanTask implements DataTask {
- private final Schema schema;
- private final Schema fileSchema;
- private final FileIO io;
- private final ManifestFile manifest;
- private final Map<Integer, PartitionSpec> specsById;
+ @Value.Immutable
+ abstract static class ManifestEntriesReadTask extends BaseFileScanTask
implements DataTask {
Review comment:
I had to rename this class because the generated Immutable class was
clashing with the `ManifestReadTask` from `DataFilesTable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
