rdblue commented on a change in pull request #3701:
URL: https://github.com/apache/iceberg/pull/3701#discussion_r771752131
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -370,14 +371,56 @@ public void alterNamespace(String[] namespace,
NamespaceChange... changes) throw
@Override
public boolean dropNamespace(String[] namespace) throws
NoSuchNamespaceException {
+ // Spark assumes that catalogs CASCADE by default. So if we have a
namespace catalog
+ /// we need to attempt to recursively delete.
if (asNamespaceCatalog != null) {
+ Namespace asNamespace = Namespace.of(namespace);
+ boolean exists = namespaceExists(namespace);
+
+ // TODO - Follow up
+ //
+ // If not exists, we can eagerly try to drop the namespace.
+ // If it throws, then that means that the user did not use IF EXISTS.
+ // If it does not throw, we can return false early as the user must have
used IF EXISTS.
+
+ // Spark only throws the catalyst version of `NoSuchNamespaceException`
if the namespace
+ // does not exist AND the user did not specify `IF EXISTS` in their
query.
+ //
+ // If the namespace does not exist, but listNamespaces didn't throw an
exception,
+ // we know the user used IF EXISTS and can return false early.
Review comment:
I don't think that we need to worry about `IF EXISTS`. If the namespace
doesn't exist, we will return false and Spark can do whatever it wants with
that information. Similarly, if Spark runs `namespaceExists` and it doesn't,
then Spark can avoid calling this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
