rdblue commented on a change in pull request #3701:
URL: https://github.com/apache/iceberg/pull/3701#discussion_r771754381
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -370,14 +371,56 @@ public void alterNamespace(String[] namespace,
NamespaceChange... changes) throw
@Override
public boolean dropNamespace(String[] namespace) throws
NoSuchNamespaceException {
+ // Spark assumes that catalogs CASCADE by default. So if we have a
namespace catalog
+ /// we need to attempt to recursively delete.
if (asNamespaceCatalog != null) {
+ Namespace asNamespace = Namespace.of(namespace);
+ boolean exists = namespaceExists(namespace);
+
+ // TODO - Follow up
+ //
+ // If not exists, we can eagerly try to drop the namespace.
+ // If it throws, then that means that the user did not use IF EXISTS.
+ // If it does not throw, we can return false early as the user must have
used IF EXISTS.
+
+ // Spark only throws the catalyst version of `NoSuchNamespaceException`
if the namespace
+ // does not exist AND the user did not specify `IF EXISTS` in their
query.
+ //
+ // If the namespace does not exist, but listNamespaces didn't throw an
exception,
+ // we know the user used IF EXISTS and can return false early.
+ String[][] subNamespaces;
try {
- return asNamespaceCatalog.dropNamespace(Namespace.of(namespace));
+ subNamespaces = listNamespaces(namespace);
} catch (org.apache.iceberg.exceptions.NoSuchNamespaceException e) {
throw new NoSuchNamespaceException(namespace);
}
- }
+ if (!exists && (subNamespaces == null || subNamespaces.length == 0)) {
+ return false;
+ }
+
+ // Recursively drop namespaces under the requested `namespace so that:
+ // 1) query has CASCADE in it and thus the base case will delete the
tables
+ // and then the namespace of those tables
+ // 2) query does not have CASCADE in it, so Spark will throw
+ // as soon as it encounters a non-empty namespace.
Review comment:
I don't think this comment is correct. Spark handles CASCADE or no
CASCADE. If this method is called, Spark either validated that the namespace is
empty OR CASCADE was set. This method doesn't need to worry about it and should
drop everything recursively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
