lirui-apache commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r777847623
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -144,13 +171,35 @@ public void stop() {
if (executorService != null) {
executorService.shutdown();
}
- if (hiveLocalDir != null) {
- hiveLocalDir.delete();
- }
if (baseHandler != null) {
baseHandler.shutdown();
}
METASTORE_THREADS_SHUTDOWN.invoke();
+ HMS_HANDLER_THREAD_LOCAL_CONF.remove();
+ HMS_HANDLER_THREAD_LOCAL_TXN.remove();
+ Object connPool = CONN_POOL.get();
+ CONN_POOL.set(null);
+ if (connPool instanceof Closeable) {
+ try {
+ ((Closeable) connPool).close();
+ } catch (IOException e) {
+ throw new RuntimeException("Failed to close connection pool in
TxnHandler", e);
+ }
+ }
+ OBJECT_STORE_PROP.set(null);
+ PersistenceManagerFactory pmf = OBJECT_STORE_PMF.get();
Review comment:
Yeah it seems `OBJECT_STORE_PROP` and `OBJECT_STORE_PMF` will be cleaned
up when connection URI changes. I took a conservative approach to clean them
anyway because I thought it does no harm and is safer than relying on hive
implementation details (especially when we have multiple versions to support).
If you prefer not to do it, I'll revert the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
