lirui-apache commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r778040932
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -220,6 +269,8 @@ private void initConf(HiveConf conf, int port) {
conf.set(HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL.varname, "false");
conf.set(HiveConf.ConfVars.METASTORE_DISALLOW_INCOMPATIBLE_COL_TYPE_CHANGES.varname,
"false");
conf.set("iceberg.hive.client-pool-size", "2");
+ // hive 1.x requires a valid DN connection pool, use bonecp as it exposes
a close method
+ conf.set("datanucleus.connectionPoolingType", "BONECP");
Review comment:
It's not an issue. BONECP is the default value. I just explicitly set it
here in case the default value changes in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
