lirui-apache commented on a change in pull request #3790:
URL: https://github.com/apache/iceberg/pull/3790#discussion_r778039885
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -144,13 +171,35 @@ public void stop() {
if (executorService != null) {
executorService.shutdown();
}
- if (hiveLocalDir != null) {
- hiveLocalDir.delete();
- }
if (baseHandler != null) {
baseHandler.shutdown();
}
METASTORE_THREADS_SHUTDOWN.invoke();
+ HMS_HANDLER_THREAD_LOCAL_CONF.remove();
+ HMS_HANDLER_THREAD_LOCAL_TXN.remove();
+ Object connPool = CONN_POOL.get();
Review comment:
I didn't find gradle/junit configurations to force test classes to run
in different threads. We can go with different JVMs, at the cost of longer test
time. Actually that's what I did when I worked on the hive integration in
flink. I believe it can be achieved by setting `forkEvery` to 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
