kbendick commented on pull request #3943:
URL: https://github.com/apache/iceberg/pull/3943#issuecomment-1019417391


   Thanks for looking into this @coolderli 
   
   my opinion would be that if we know something doesn’t currently happen, we 
should update it when it does become an issue
   
    It’s easier to track that way as the changes are around the same time (and 
can more easily reference each other). Also, it’s always possible that changes 
we make defensively for future possible changes might never pan out and then we 
wouldn’t need this change.
   
   so it’s typically best to wait until it’s an actual issue. that said, there 
are always exceptions I suppose.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to