rdblue commented on a change in pull request #3943:
URL: https://github.com/apache/iceberg/pull/3943#discussion_r790311151
##########
File path: core/src/test/java/org/apache/iceberg/TestDeleteFileIndex.java
##########
@@ -397,4 +397,57 @@ public void testUnpartitionedTableSequenceNumbers() throws
IOException {
Assert.assertEquals("Should have only pos delete file",
unpartitionedPosDeleteFile.path(), task.deletes().get(0).path());
}
+
+ @Test
+ public void testPartitionedTableWithExistingDeleteFile() {
+ table.updateProperties()
+ .set(TableProperties.MANIFEST_MERGE_ENABLED, "false")
+ .commit();
+
+ table.newAppend()
+ .appendFile(FILE_A)
+ .commit();
+
+ table.newRowDelta()
+ .addDeletes(FILE_A_EQ_1)
+ .commit();
+
+ table.newRowDelta()
+ .addDeletes(FILE_A_POS_1)
+ .commit();
+
+ table.updateProperties()
+ .set(TableProperties.MANIFEST_MIN_MERGE_COUNT, "1")
+ .set(TableProperties.MANIFEST_MERGE_ENABLED, "true")
+ .commit();
+
+ Assert.assertEquals("Should have two delete manifest",
+ 2, table.currentSnapshot().deleteManifests().size());
+
+ // merge delete manifests
+ table.newAppend()
+ .appendFile(FILE_B)
+ .commit();
+
+ Assert.assertEquals("Should have one delete manifest",
+ 1, table.currentSnapshot().deleteManifests().size());
+ Assert.assertEquals("Should have one existing delete file",
+ 0,
table.currentSnapshot().deleteManifests().get(0).addedFilesCount().intValue());
+ Assert.assertEquals("Should have one existing delete file",
+ 0,
table.currentSnapshot().deleteManifests().get(0).deletedFilesCount().intValue());
+ Assert.assertEquals("Should have one existing delete file",
+ 2,
table.currentSnapshot().deleteManifests().get(0).existingFilesCount().intValue());
+
+ List<FileScanTask> tasks =
Lists.newArrayList(table.newScan().planFiles().iterator());
Review comment:
I think this should filter by partition so that only FILE_A matches.
Otherwise, `tasks.get(1)` is brittle and could cause test failures later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
