rdblue commented on a change in pull request #3943:
URL: https://github.com/apache/iceberg/pull/3943#discussion_r790312596
##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -462,7 +462,7 @@ DeleteFileIndex build() {
Iterable<ManifestFile> matchingManifests = evalCache == null ?
deleteManifests :
Iterables.filter(deleteManifests, manifest ->
manifest.content() == ManifestContent.DELETES &&
- (manifest.hasAddedFiles() || manifest.hasDeletedFiles()) &&
+ (manifest.hasAddedFiles() || manifest.hasDeletedFiles() ||
manifest.hasExistingFiles()) &&
Review comment:
Actually, I'm wondering if the original intent of this was to check for
added or existing files, but ignore manifests with only deleted files. I think
it should probably be `(manifest.hasAddedFiles() ||
manifest.hasExistingFiles()) &&`. Can you try that out instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
