aokolnychyi commented on a change in pull request #3945:
URL: https://github.com/apache/iceberg/pull/3945#discussion_r791185127
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -89,6 +89,7 @@
private final List<ManifestFile> rewrittenAppendManifests =
Lists.newArrayList();
private final SnapshotSummary.Builder addedFilesSummary =
SnapshotSummary.builder();
private final SnapshotSummary.Builder appendedManifestsSummary =
SnapshotSummary.builder();
+ private final Set<StructLike> changedPartitions = Sets.newHashSet();
Review comment:
That's a very good point.
We should either use `PartitionSet` if we need to have partitions per spec
or just use `StructLikeSet`. We cannot use a regular set as we may get
arbitrary StructLike implementations. Most likely, we will need `PartitionSet`.
Can we add a test with multiple specs?
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -89,6 +89,7 @@
private final List<ManifestFile> rewrittenAppendManifests =
Lists.newArrayList();
private final SnapshotSummary.Builder addedFilesSummary =
SnapshotSummary.builder();
private final SnapshotSummary.Builder appendedManifestsSummary =
SnapshotSummary.builder();
+ private final Set<StructLike> changedPartitions = Sets.newHashSet();
Review comment:
That's a very good point.
We should either use `PartitionSet` if we need to have partitions per spec
or just use `StructLikeSet`. We cannot use a regular set as we may get
arbitrary StructLike implementations.
Most likely, we will need `PartitionSet`. Can we add a test with multiple
specs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
