coolderli commented on a change in pull request #3945:
URL: https://github.com/apache/iceberg/pull/3945#discussion_r791394258
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -182,20 +183,23 @@ protected void dropPartition(int specId, StructLike
partition) {
// dropping the data in a partition also drops all deletes in the partition
filterManager.dropPartition(specId, partition);
deleteFilterManager.dropPartition(specId, partition);
+ changedPartitions.add(partition);
Review comment:
Yes, I think this spec ID should matter.
##########
File path:
core/src/test/java/org/apache/iceberg/TestOverwriteWithValidation.java
##########
@@ -333,6 +333,31 @@ public void
testOverwriteCompatibleAdditionStrictValidated() {
committedSnapshotId, table.currentSnapshot().snapshotId());
}
+ @Test
+ public void testOverwriteCompatibleAdditionStrictValidatedNoConflict() {
Review comment:
@aokolnychyi Thanks, I think a partition predicate will work. But I
worry about that because using the hidden partition we may not know which
partition should be filtered. If we use a partition like `bucket`, I don't know
how to express this predicate.
##########
File path:
core/src/test/java/org/apache/iceberg/TestOverwriteWithValidation.java
##########
@@ -333,6 +333,31 @@ public void
testOverwriteCompatibleAdditionStrictValidated() {
committedSnapshotId, table.currentSnapshot().snapshotId());
}
+ @Test
+ public void testOverwriteCompatibleAdditionStrictValidatedNoConflict() {
Review comment:
Maybe we should use other partitions, but this brings more difficulties
for users to write SQL. Users must be concerned about the partition
distribution of data. In the above example, the files of partition A and
partition B will not conflict, but they will still conflict at present because
there is no partition predicate in SQL. Users may feel confused because
conflict resolution should be the concern of iceberg, not users. I means if
concurrent submission does not conflict, we should allow submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
