rdblue commented on a change in pull request #3945:
URL: https://github.com/apache/iceberg/pull/3945#discussion_r791201865
##########
File path:
core/src/test/java/org/apache/iceberg/TestOverwriteWithValidation.java
##########
@@ -333,6 +333,31 @@ public void
testOverwriteCompatibleAdditionStrictValidated() {
committedSnapshotId, table.currentSnapshot().snapshotId());
}
+ @Test
+ public void testOverwriteCompatibleAdditionStrictValidatedNoConflict() {
Review comment:
Yeah, this seems reasonable to me. The filter here is overbroad. It is
literally telling Iceberg that if any data is added, then it conflicts with the
overwrite. That means the test case is invalid. Writes can affect what would
have been read without necessarily showing up in what is written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
