szehon-ho commented on pull request #4050: URL: https://github.com/apache/iceberg/pull/4050#issuecomment-1035692060
@danielcweeks yea I had a follow up comment later where I agree the generic API is better, sorry for confusion :). I was just initially mistaken that FileIOMetric implementation was meant to support only specific metrics because: - The only example HadoopFileIOMetrics is expecting only the metrics of S3FileIO and throws IllegalArgumentException otherwise, so it's actually not generic. - FileIOMetrics interface has all the metrics constants, so I thought only that dictates what can be called by FileIO's. So my follow-up comment was maybe HadoopFileIOMetrics could be clarified to be specific to S3FileIO for now by mentioning in the comments or moving from Hadoop to S3 package? Otherwise other FileIO's loading the generic interface might expect the implementation to be able to support any metric name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
