rdblue commented on a change in pull request #4050:
URL: https://github.com/apache/iceberg/pull/4050#discussion_r804173167
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -215,6 +215,12 @@
public static final String S3_CHECKSUM_ENABLED = "s3.checksum-enabled";
public static final boolean CLIENT_ENABLE_ETAG_CHECK_DEFAULT = false;
+ /**
+ * FileIOMetrics implementation class used to report metrics
+ */
+ public static final String S3_FILEIO_METRICS_IMPL = "s3.fileio.metrics-impl";
Review comment:
What's the benefit of making this dynamic? I thought this was just an
adapter that can be used to record metrics in `FileIO`. Shouldn't that be the
same and we just customize what accepts the metrics later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
