kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r809540515
########## File path: core/src/main/java/org/apache/iceberg/rest/requests/UpdateNamespacePropertiesRequest.java ########## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import java.util.List; +import java.util.Map; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; + +/** + * A REST request to set and/or remove properties on a namespace. + * <p> + * The request body specifies a list of properties to remove and a map + * of key value pairs to update. + * <p> + * Properties that are not in the request are not modified or removed by this call. + * Server implementations are not required to support namespace properties. + */ +public class UpdateNamespacePropertiesRequest { + + private List<String> removals; + private Map<String, String> updates; + + public UpdateNamespacePropertiesRequest() { + // Required for Jackson deserialization. + } + + private UpdateNamespacePropertiesRequest(List<String> removals, Map<String, String> updates) { + this.removals = removals; + this.updates = updates; + validate(); + } + + UpdateNamespacePropertiesRequest validate() { + Preconditions.checkArgument((removals != null && !removals.isEmpty()) || (updates != null && !updates.isEmpty()), + "Cannot create a request to update a namespace's properties without specifying any props to update or remove"); + return this; + } + + public List<String> removals() { + return removals == null ? ImmutableList.of() : removals; + } + + public Map<String, String> updates() { + return updates == null ? ImmutableMap.of() : updates; + } + + @Override + public String toString() { + return MoreObjects.toStringHelper(this) + .add("removals", removals) + .add("updates", updates) + .toString(); + } + + public static Builder builder() { + return new Builder(); + } + + public static class Builder { + private final ImmutableSet.Builder<String> removalsBuilder = ImmutableSet.builder(); + private final ImmutableMap.Builder<String, String> updatesBuilder = ImmutableMap.builder(); + + private Builder() { + } + + public Builder remove(String removal) { + Preconditions.checkNotNull(removal, + "Cannot pass null key to remove to UpdateNamespacePropertiesRequest.Builder"); + removalsBuilder.add(removal); + return this; + } + + public Builder removeAll(Iterable<String> removals) { + Preconditions.checkNotNull(removals, + "Cannot pass null removals to UpdateNamespacePropertiesRequest.Builder"); + removalsBuilder.addAll(removals); + return this; + } + + public Builder update(String key, String value) { + Preconditions.checkNotNull(key, + "Cannot pass null key to update to UpdateNamespacePropertiesRequest.Builder"); + Preconditions.checkNotNull(value, + "Cannot pass null value to update in UpdateNamespacePropertiesRequest.Builder. Use remove instead"); + updatesBuilder.put(key, value); + return this; + } + + public Builder updateAll(Map<String, String> updates) { + Preconditions.checkNotNull(updates, + "Cannot pass null updates to UpdateNamespacePropertiesRequest.Builder"); Review comment: Thrown and tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
