kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r809724116
########## File path: core/src/main/java/org/apache/iceberg/rest/responses/GetNamespaceResponse.java ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.responses; + +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +/** + * Represents a REST response to fetch a namespace and its metadata properties + */ +public class GetNamespaceResponse { + + private Namespace namespace; + private Map<String, String> properties; + + public GetNamespaceResponse() { + // Required for Jackson deserialization + } + + private GetNamespaceResponse(Namespace namespace, Map<String, String> properties) { + this.namespace = namespace; + this.properties = properties; + validate(); + } + + GetNamespaceResponse validate() { + Preconditions.checkArgument(namespace != null && !namespace.isEmpty(), + "Cannot build a response to get a namespace without specifying the namespace"); + return this; + } + + public Namespace namespace() { + return namespace; + } + + public Map<String, String> properties() { + return properties != null ? properties : ImmutableMap.of(); + } + + @Override + public String toString() { + return MoreObjects.toStringHelper(this) + .add("namespace", namespace) + .add("properties", properties) + .toString(); + } + + public static Builder builder() { + return new Builder(); + } + + static class Builder { + private Namespace namespace; + private final ImmutableMap.Builder<String, String> properties = ImmutableMap.builder(); + + private Builder() { + } + + public Builder withNamespace(Namespace ns) { + Preconditions.checkNotNull(ns, "Invalid namespace to have requested: null"); + namespace = ns; + return this; + } + + public Builder setProperties(Map<String, String> props) { + Preconditions.checkNotNull("Invalid collection of properties for a namespace: null"); + Preconditions.checkArgument(!props.containsKey(null), + "Invalid property in collection of namespace properties: null"); + Preconditions.checkArgument(!props.containsValue(null), + "Invalid value for properties %s: null", + Maps.filterValues(props, Objects::isNull).keySet()); Review comment: The second two `Preconditions` checks are needed, as we can't pass `null` elements to the `ImmutableMap.Builder`. However, does the first preconditon chck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
